Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom-resources): module is now stable :) #6584

Merged
merged 9 commits into from
Mar 4, 2020

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Mar 4, 2020

I marked this as a feature so it will show up in the release notes.

We should probably think of something nicer in the future.
This also means this PR needs to be merged manually because the PR linter will fail since there no test file changed.

Commit Message

feat(custom-resources): module is now stable :) (#6584)

Resolves #5873


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 4, 2020
@iliapolo iliapolo changed the title chore(custom-resources): module is now stable! feat(custom-resources): module is now stable :) Mar 4, 2020
@iliapolo iliapolo requested review from eladb, nija-at and ccfife March 4, 2020 14:36
@iliapolo iliapolo added the pr/do-not-merge This PR should not be merged at this time. label Mar 4, 2020
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!

Thanks @jogold for all your contributions!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 96671ba
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@iliapolo
Copy link
Contributor Author

iliapolo commented Mar 4, 2020

Congratulations!

Thanks @jogold for all your contributions!

Here here! @jogold you rock!

Congrats to all :)

@iliapolo iliapolo added pr/do-not-merge This PR should not be merged at this time. and removed pr/do-not-merge This PR should not be merged at this time. labels Mar 4, 2020
@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@iliapolo iliapolo removed the pr/do-not-merge This PR should not be merged at this time. label Mar 4, 2020
@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 88987b3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@iliapolo iliapolo merged commit a2a738c into master Mar 4, 2020
@iliapolo iliapolo deleted the epolon/graduate-custom-resources branch March 4, 2020 16:34
horsmand pushed a commit to horsmand/aws-cdk that referenced this pull request Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graduate @aws-cdk/custom-resources to stable
3 participants