Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda): ruby 2.7 runtime #7024

Merged
merged 11 commits into from
Apr 1, 2020
Merged

feat(lambda): ruby 2.7 runtime #7024

merged 11 commits into from
Apr 1, 2020

Conversation

DerkSchooltink
Copy link
Contributor

@DerkSchooltink DerkSchooltink commented Mar 26, 2020 •
edited by RomainMuller
Loading

Commit Message

feat(lambda): ruby 2.7 runtime (#7024)

closes #6979

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@DerkSchooltink
Copy link
Contributor Author

PR linter fails because no changes to README files. AFAIK the runtime options aren't documented in the README's.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 113b2d1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@RomainMuller
Copy link
Contributor

I wouldn't worry about the README requirement here. We probably will simply ignore this and merge the PR.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7f427c7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3449b7a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

RomainMuller
RomainMuller previously approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the diligence!! That is much appreciated!

@mergify mergify bot dismissed RomainMuller’s stale review March 30, 2020 13:59

Pull request has been modified.

nija-at
nija-at previously approved these changes Mar 30, 2020
View reviewed changes
@nija-at nija-at changed the title feat(lambda): add ruby 2.7 support for Lambda runtimes feat(lambda): ruby 2.7 runtime Mar 30, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d93c11b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a4bd13e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@DerkSchooltink
Copy link
Contributor Author

Build failure due to:

@aws-cdk/aws-lambda: error: [awslint:docs-public-apis:@aws-cdk/aws-lambda.Runtime.DOTNET_CORE_2] Public API element must have a docstring 
@aws-cdk/aws-lambda: error: [awslint:docs-public-apis:@aws-cdk/aws-lambda.Runtime.DOTNET_CORE_1] Public API element must have a docstring 
@aws-cdk/aws-lambda: error: [awslint:docs-public-apis:@aws-cdk/aws-lambda.Runtime.NODEJS] Public API element must have a docstring 
@aws-cdk/aws-lambda: error: [awslint:docs-public-apis:@aws-cdk/aws-lambda.Runtime.NODEJS_4_3] Public API element must have a docstring 
@aws-cdk/aws-lambda: error: [awslint:docs-public-apis:@aws-cdk/aws-lambda.Runtime.NODEJS_6_10] Public API element must have a docstring 
@aws-cdk/aws-lambda: error: [awslint:docs-public-apis:@aws-cdk/aws-lambda.Runtime.NODEJS_8_10] Public API element must have a docstring

I don't quite get this one... They are documented, right? 🤯

@nija-at
Copy link
Contributor

nija-at commented Mar 30, 2020

don't quite get this one... They are documented, right? 🤯

Whoops. I think the linter is more sensitive than it should be.
The @deprecated should come after the document string. Could you switch this around?

@mergify mergify bot dismissed nija-at’s stale review March 30, 2020 14:54

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 0c653c0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@DerkSchooltink DerkSchooltink requested a review from nija-at March 30, 2020 15:45
@nija-at nija-at added the pr-linter/exempt-readme The PR linter will not require README changes label Apr 1, 2020
nija-at
nija-at previously approved these changes Apr 1, 2020
View reviewed changes
@mergify mergify bot dismissed nija-at’s stale review April 1, 2020 07:57

Pull request has been modified.

@nija-at nija-at added the pr-linter/exempt-test The PR linter will not require test changes label Apr 1, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a3f679e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4994e0d into aws:master Apr 1, 2020
@michaeldimoudis michaeldimoudis mentioned this pull request Apr 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

@RomainMuller RomainMuller RomainMuller left review comments

Assignees

@nija-at nija-at

Labels
pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Lambda Runtime Version Ruby2.7
5 participants
@DerkSchooltink @aws-cdk-automation @RomainMuller @nija-at @DerkSch