Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dynamodb): do not install aws-sdk in replica handler #7047

Merged
merged 11 commits into from
Apr 27, 2020
Merged

chore(dynamodb): do not install aws-sdk in replica handler #7047

merged 11 commits into from
Apr 27, 2020

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Mar 27, 2020 •
edited by RomainMuller
Loading

Commit Message

chore(dynamodb): do not install aws-sdk in replica handler (#7047)

The Node.js 12.x runtime now comes with AWS SDK for JavaScript v2.631.0. Installation
of the latest version is no longer necessary (ReplicaUpdates has been introduced in
v2.577.0).

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jogold
chore(dynamodb): do not install aws-sdk in replica handler
a730f46 
The Node.js 12.x runtime now comes with AWS SDK for JavaScript v2.631.0. Installation
of the latest version is no longer necessary (`ReplicaUpdates` has been introduced in
v2.577.0).
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a730f46
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: aca6e8b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold
Copy link
Contributor Author

jogold commented Apr 1, 2020 •
edited
Loading

awsdocs/aws-lambda-developer-guide#171

https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: bb94a7f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@RomainMuller
Copy link
Contributor

@jogold thanks for that! Have you been able to run the integration tests over this change (I wanna make sure this deploys cleanly, still - the code looks okay, but runtime can be treacherous)? I can do it otherwise...

@RomainMuller RomainMuller self-requested a review April 15, 2020 09:31
@RomainMuller RomainMuller added @aws-cdk/aws-dynamodb Related to Amazon DynamoDB review/small labels Apr 15, 2020
@jogold
Copy link
Contributor Author

jogold commented Apr 15, 2020

@jogold thanks for that! Have you been able to run the integration tests over this change (I wanna make sure this deploys cleanly, still - the code looks okay, but runtime can be treacherous)? I can do it otherwise...

Yes, updated the .expected.json by running the integ test here.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: bd87b62
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c132769
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

RomainMuller
RomainMuller previously approved these changes Apr 22, 2020
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Apr 22, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@RomainMuller
Copy link
Contributor

Ergh... this got merge conflicted on the integration test expectations... 😔

I'll get back here and resolve that unless you beat me to it 😅

@jogold
Copy link
Contributor Author

jogold commented Apr 22, 2020

I'll get back here and resolve that unless you beat me to it 😅

on it

@RomainMuller
Copy link
Contributor

I'll get back here and resolve that unless you beat me to it 😅

on it

@mergify mergify bot dismissed RomainMuller’s stale review April 22, 2020 09:17

Pull request has been modified.

@jogold jogold requested a review from RomainMuller April 22, 2020 09:49
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 9c956c6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2209bf7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: bb8d9dd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold
Copy link
Contributor Author

jogold commented Apr 27, 2020

@RomainMuller can you check again?

@mergify
Copy link
Contributor

mergify bot commented Apr 27, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a330652
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: eaf801a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 27, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9aff357 into aws:master Apr 27, 2020
@jogold jogold deleted the dynamodb-aws-sdk-no-install branch April 27, 2020 12:18
@mcalello mcalello mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

@RomainMuller RomainMuller

Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jogold @aws-cdk-automation @RomainMuller