Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: remove resource attribute types for string attributes #712

Merged
merged 16 commits into from
Sep 19, 2018
Merged

BREAKING CHANGE: remove resource attribute types for string attributes #712

merged 16 commits into from
Sep 19, 2018

Commits on Sep 13, 2018

  1. Initial commit

    Elad Ben-Israel committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    a456155 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2018

  1. Merge remote-tracking branch 'origin/master' into benisrae/remove-att… 

    …ribute-types
    Elad Ben-Israel committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    999b1e9 View commit details
    Browse the repository at this point in the history

  2. Updates 

    * Converted all attribute types to strings
* Remove a stale example from aws-cloudformation
* Add `--no-bail` to `build.sh` so it won't stop on the first error
* Reduce some verbosity from cdk-build and cfn2ts
    Elad Ben-Israel committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    32da352 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into benisrae/remove-att… 

    …ribute-types
    Elad Ben-Israel committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    00f4672 View commit details
    Browse the repository at this point in the history

  4. Fix breaks after merge

    Elad Ben-Israel committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    8ac4942 View commit details
    Browse the repository at this point in the history

  5. Use ref instead of getatt for subnet id

    Elad Ben-Israel committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    73b5a37 View commit details
    Browse the repository at this point in the history

  6. Update expecations

    Elad Ben-Israel committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    acb96b7 View commit details
    Browse the repository at this point in the history

  7. Fix codebuild tests

    Elad Ben-Israel committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    b9f52a7 View commit details
    Browse the repository at this point in the history

  8. Update codebuild test

    Elad Ben-Israel committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    3ad255b View commit details
    Browse the repository at this point in the history

  9. Update codepipeline integ test

    Elad Ben-Israel committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    449e961 View commit details
    Browse the repository at this point in the history

  10. update test to no-bail and codepipeline

    Elad Ben-Israel committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    934e0a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. CR followups 

    * Fix typo "managedPolicieArns" => "managedPolicyArns"
* Remove unneeded `.toString`
* Rename `isToken(x)` to `unresolved(x)`
* Rename cfn2ts `ClassDeclaration` to `AttributeTypeDeclaration`
* Revert log "generated code up-to-date" from cfn2ts
    Elad Ben-Israel committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    a1b5755 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into benisrae/remove-att… 

    …ribute-types
    Elad Ben-Israel committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    8e3ea6c View commit details
    Browse the repository at this point in the history

  3. Fix build break

    Elad Ben-Israel committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    51b2924 View commit details
    Browse the repository at this point in the history

  4. More followups 

    * Restore custom resource example
* Change `resource.getAtt` to return a token
    Elad Ben-Israel committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    d84b871 View commit details
    Browse the repository at this point in the history

  5. Fix build break and announce errors

    Elad Ben-Israel committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    3817d21 View commit details
    Browse the repository at this point in the history