Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appsync): export configured API key #7380

Merged
merged 2 commits into from
May 3, 2020

Conversation

duarten
Copy link
Contributor

@duarten duarten commented Apr 16, 2020

Commit Message

feat(appsync): export configured API key

If an AppSync API is configured with the API key authorization mode,
then export it so it can be consumed as a stack output.

Signed-off-by: Duarte Nunes duarte@uma.ni

End Commit Message


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 701846f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

If an AppSync API is configured with the API key authorization mode,
then export it so it can be consumed as a stack output.

Signed-off-by: Duarte Nunes <duarte@uma.ni>
@duarten duarten force-pushed the origin/appsync-apikey branch from 701846f to e44d153 Compare April 16, 2020 04:25
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: e44d153
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@duarten
Copy link
Contributor Author

duarten commented May 3, 2020

Ping.

@MrArnoldPalmer
Copy link
Contributor

Sorry I lost this in my notifications somewhere. Checking it out

MrArnoldPalmer
MrArnoldPalmer previously approved these changes May 3, 2020
@duarten
Copy link
Contributor Author

duarten commented May 3, 2020

And I missed that it wasn't passing the commit message linting. Should I add an entry the readme, or change the tag from "feat" to something else?

@mergify mergify bot dismissed MrArnoldPalmer’s stale review May 3, 2020 23:25

Pull request has been modified.

@MrArnoldPalmer
Copy link
Contributor

@duarten I updated from master and I'll merge it manually since this is a private change.

@MrArnoldPalmer MrArnoldPalmer merged commit fa8c13c into aws:master May 3, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5e0e85b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@duarten duarten deleted the origin/appsync-apikey branch February 17, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants