Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ec2): EBS volume configuration for BastionHostLinux #7585

Merged
merged 9 commits into from
May 6, 2020
Merged

feat(ec2): EBS volume configuration for BastionHostLinux #7585

merged 9 commits into from
May 6, 2020

Conversation

shreyasdamle
Copy link
Contributor

@shreyasdamle shreyasdamle commented Apr 24, 2020 •
edited by rix0rrr
Loading

Commit Message

feat(ec2): EBS volume configuration for BastionHostLinux

Added blockDevices? property to BastionHostLinuxProps to allow full EBS device configuration so that customers can use it for use-cases like to encrypt an EBS volume for BastionHostLinux

Fixes #6945

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ae8e555
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ccd0f34
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 89fee46
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 4c956df
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shreyasdamle
Copy link
Contributor Author

Sorry, I'm not sure why this request is showing commits that are already in master branch. However, this link will show the correct comparison: https://github.com/aws/aws-cdk/compare/master...shreyasdamle:sdamle-ec2?diff=split

rix0rrr
rix0rrr previously requested changes May 4, 2020
View reviewed changes
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to have a number of unrelated changes in it. Please pare it down to the changes that apply to the issue you're trying to fix.

@mergify mergify bot dismissed rix0rrr’s stale review May 4, 2020 16:35

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c4ecb17
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b6d3d2a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: edaf092
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shreyasdamle shreyasdamle requested a review from rix0rrr May 4, 2020 18:29
@shreyasdamle
Copy link
Contributor Author

@rix0rrr Thanks for the review.

I have removed unrelated changes from this PR. Please let me know if I missed anything.

rix0rrr
rix0rrr previously requested changes May 5, 2020
View reviewed changes
packages/@aws-cdk/aws-ec2/lib/bastion-host.ts Outdated
*
* @default false
*/
readonly ebsVolumeEncryption?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we're going to go here, we need full EBS device configuration support, just like we have on ec2.Instance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback!

I have made the requested changes.

@mergify mergify bot dismissed rix0rrr’s stale review May 5, 2020 18:46

Pull request has been modified.

@shreyasdamle shreyasdamle requested a review from rix0rrr May 5, 2020 18:51
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: eb2d7f6
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d9359d3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr changed the title feat(ec2): support EBS volume encryption for BastionHostLinux feat(ec2): EBS volume configuration for BastionHostLinux May 6, 2020
@mergify
Copy link
Contributor

mergify bot commented May 6, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 705c736
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 6, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 207a8ec into aws:master May 6, 2020
@shreyasdamle shreyasdamle deleted the sdamle-ec2 branch May 6, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BastionHostLinux does not encrypt EBS volume
3 participants
@shreyasdamle @aws-cdk-automation @rix0rrr