Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amplify): cannot map branch to domain root #7621

Merged
merged 4 commits into from
May 3, 2020
Merged

fix(amplify): cannot map branch to domain root #7621

merged 4 commits into from
May 3, 2020

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Apr 27, 2020 •
edited
Loading

Commit Message

fix(amplify): cannot map branch to domain root (#7621)

Correctly handle the default for prefix. An empty string now maps to the domain
root. Also add a mapRoot method.

Closes #7590

BREAKING CHANGE: mapSubDomain() called with an empty string for prefix now
maps to the domain root.

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jogold
fix(amplify): cannot map branch to domain root
6c4f8a2 
Correctly handle the default for `prefix`. An empty string now maps to the domain
root. Also add a `mapRoot` method.

Closes aws#7590
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 6c4f8a2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: e43e2f0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

MrArnoldPalmer
MrArnoldPalmer requested changes May 3, 2020
View reviewed changes
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jogold lets add a breaking change note in the PR message just to be safe? I doubt there are users currently using prefix: '' in the wild but better safe.

@jogold
Copy link
Contributor Author

jogold commented May 3, 2020

@jogold lets add a breaking change note in the PR message just to be safe? I doubt there are users currently using prefix: '' in the wild but better safe.

done

@mergify
Copy link
Contributor

mergify bot commented May 3, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fe73598
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 3, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit da7c508 into aws:master May 3, 2020
@jogold jogold deleted the amplify-root branch May 31, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrArnoldPalmer MrArnoldPalmer MrArnoldPalmer approved these changes

Assignees

@MrArnoldPalmer MrArnoldPalmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Amplify Domain always gets a subdomain
3 participants
@jogold @aws-cdk-automation @MrArnoldPalmer