feat(ec2): access a vpc's internet gateway

[shearn89]

This commit introduces a new internetGateway attribute to the VPC
construct to allow for creative routing using the default IGW added
with when using a public subnet.

Resolves #5327

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Pull request has been modified.

[shearn89]

I've made that change, I'll try and run through the integration tests at some point to confirm that works as well.

[shearn89]

Integration tests running now.

[shearn89]

The integration tests all pass but 2: integ.vpc-endpoint-service.js which complains about InvalidNetworkLoadBalancerArn.NotFound, and also integ.vpc-endpoint-service-cn.js which complains about credentials.

These don't appear to be failures caused by my code, so I think this should be ready for review and merge.

[shearn89]

Hi @iliapolo/@rix0rrr - any chance of a review soon?

[iliapolo]

Hi @shearn89. Yes I will take a look at this soon. In the meantime notice you have a conflict...

[shearn89]

Brill, thanks - Ah, I hadn't spotted that since last commenting, will address those this evening!

[iliapolo]

Hi @shearn89 - Thanks for this PR!

Im not sure I understand why we need the whole IInternetGateway interface and its complexity.
It seems like all we want to do is expose the internetGatewayId of a newly created VPC - right?

So why not just have:

public readonly internetGatewayId: string;

Only on the VPC class, and assign its value in the constructor:

this.internetGatewayId = igw.ref;

This way all imported VPC's won't even have this attribute available to them, which is ok since its not supported anyway.

Am I missing something?

Also, The documentation doesn't really emphasize the feature you are adding, but rather shows a specific use-case. Lets be clear about what the feature is:

Accessing the Internet Gateway

<explain its only supported for VPC's created in the stack, not imported ones>
<give an example use-case - like you do, but see if you can find one without having to downcast objects).

[github-actions]

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

[shearn89]

Hi @iliapolo: okay, that makes sense! TypeScript is not my forte so I copied what was already there, slightly missing the point of the interface. I'll try to get the PR updated this weekend if I can!

Pull request has been modified.

[shearn89]

Okay! Apologies for the mess/notification spam, had a shocker when I tried to update from master. Should be all fixed now, with only the changes I actually made!

[shearn89]

Cool, thanks for the comments. I'm busy today but will pick this up this week and get it updated.

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 06dbe28
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).