-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stepfunctions): new service integration classes for Lambda, SNS, and SQS #7946
Conversation
…task and state functionality
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Why? |
packages/@aws-cdk/aws-stepfunctions-tasks/lib/private/task-utils.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/private/task-utils.ts
Outdated
Show resolved
Hide resolved
I had a TODO in the comment, you addressed it though. Since users can insert the token anywhere in the payload (for Lambda), we can't ditch it. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Looking good and looking forward to trying these out |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Don't forget a unit test on
|
it's here |
Co-authored-by: Rico Huijbers <rix0rrr@gmail.com>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…thub.com/aws/aws-cdk into shivlaks/sfn-merge-task-and-state-lambda
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
… and SQS (aws#7946) merge functionality currently modeled under task and state into a single object that represents a task state as an abstract class. Service integrations extend the base class and add service specific configuration, metrics, and policies. this commit introduces the "new" service integrations for Lambda, SNS, and SQS Motivation: The current service integrations that are offered in `aws-stepfunctions-tasks` all currently implement a `bind()` method and contribute a portion of the configuration that creates a `Task` state. However, it's often useful to configure state level properties such as paths, retries, errors based on the service integration and the pattern that has been requested. Implementation: * Duplicate the current `Task` class and merge the properties of a task state and a task service integration into a new abstract base class. * Concrete implementation per service integration class where all of the best practices and user intents can be encoded * After all the service integrations have been migrated, we will want to retire the `Task` class as well since we don't want it to be instantiated. Paves the way for: aws#6715 by simplifying the invocation of service integration calls. We would be able to start adding properties such as retries and errors. aws#6489 where we will be making service integrations consistent ### End Commit Message ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
merge functionality currently modeled under task and state into a single object that represents a task state as an abstract class. Service integrations extend the base class and add service specific configuration, metrics, and policies.
this commit introduces the "new" service integrations for Lambda, SNS, and SQS
Motivation:
The current service integrations that are offered in
aws-stepfunctions-tasks
all currently implement abind()
method and contribute a portion of the configuration that creates aTask
state.However, it's often useful to configure state level properties such as paths, retries, errors based on the service integration and the pattern that has been requested.
Implementation:
Task
class and merge the properties of a task state and a task service integration into a new abstract base class.Task
class as well since we don't want it to be instantiated.Paves the way for:
#6715 by simplifying the invocation of service integration calls. We would be able to start adding properties such as retries and errors.
#6489 where we will be making service integrations consistent
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license