fix(certificate-manager): Wait for all subject alternative resource records to be available. #7996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
magJ
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
SomayaB
changed the title
skinny85
suggested changes
Jun 8, 2020
There was a problem hiding this comment.
The build failure is because the body of the custom resource changed, and thus the names of the parameters representing the assets for the custom resource also changed in the @aws-cdk/aws-ecs module's tests (they are named based on the hash of the source of the custom resource).
Can you update those @magJ ? I'll approve the change after the build passes.
Thanks again!
jogold
added a commit
to jogold/aws-cdk
that referenced
this pull request
Jun 15, 2020
…icate Automatically adding Amazon Route 53 CNAME records for DNS validation is now natively supported by CloudFormation. Add a `validation` prop to `Certificate` to handle both email and DNS validation. Deprecate `DnsValidatedCertificate`. The default remains email validation (non-breaking). Closes aws#5831 Closes aws#5835 Closes aws#6081 Closes aws#6516 Closes aws#7150 Closes aws#7941 Closes aws#7995 Closes aws#7996
jogold
added a commit
to jogold/aws-cdk
that referenced
this pull request
Jun 15, 2020
…cate Automatically adding Amazon Route 53 CNAME records for DNS validation is now natively supported by CloudFormation. Add a `validation` prop to `Certificate` to handle both email and DNS validation. Deprecate `DnsValidatedCertificate`. The default remains email validation (non-breaking). Closes aws#5831 Closes aws#5835 Closes aws#6081 Closes aws#6516 Closes aws#7150 Closes aws#7941 Closes aws#7995 Closes aws#7996
|
I'll just close this in favor of #8552, getting the entire build/tests of this project working locally takes a lot of screwing around, and the docker build doesn't seem to be maintained(there are numerous issues open for this). |
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2020
…cate (#8552) Automatically adding Amazon Route 53 CNAME records for DNS validation is now natively supported by CloudFormation. Add a `validation` prop to `Certificate` to handle both email and DNS validation. `DnsValidatedCertificate` is now only useful for cross-region certificate creation. The default remains email validation (non-breaking). Closes #5831 Closes #5835 Closes #6081 Closes #6516 Closes #7150 Closes #7941 Closes #7995 Closes #7996 Closes #8282 Closes #8659 Closes #8783 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
Wait for all subject alternative resource records to be available.
The DNS validated certificate handler, only waits for the first certificate
ResourceRecordto be available.This can be a problem when using subject alternative names, as the resource records arent necessarily all made available at the same time.
Thus we must wait for them all to be provided, before proceeding.
End Commit Message
Fixes #7995
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license