Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stepfunctions): support paths in Pass state #8070

Merged
merged 5 commits into from
May 24, 2020
Merged

feat(stepfunctions): support paths in Pass state #8070

merged 5 commits into from
May 24, 2020

Conversation

shivlaks
Copy link
Contributor

The Pass state supports JsonPath values in the parameters
field to filter the state input and serve as input to the field.

Added a method to render parameters which will generate the ASL
JSON format if a path is used in a parameter.

Closes #7181

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@shivlaks
feat(stepfunctions): support paths in Pass state
a5a7566 
The Pass state supports JsonPath values in the `parameters`
field to filter the state input and serve as input to the field.

Added a method to render parameters which will generate the ASL
JSON format if a path is used in a parameter.

Closes #7181
@shivlaks shivlaks added the @aws-cdk/aws-stepfunctions Related to AWS StepFunctions label May 19, 2020
@shivlaks shivlaks requested review from rix0rrr, nija-at and a team May 19, 2020 02:52
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 19, 2020
@ccfife ccfife mentioned this pull request May 19, 2020
Closed
24 tasks
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a5a7566
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shivlaks shivlaks marked this pull request as draft May 20, 2020 10:00
@shivlaks shivlaks marked this pull request as ready for review May 20, 2020 17:15
@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label May 22, 2020
nija-at
nija-at approved these changes May 22, 2020
View reviewed changes
@shivlaks
Apply suggestions from code review
d11b9fe 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d11b9fe
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b62cd32
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c3a49b7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shivlaks shivlaks removed the pr/do-not-merge This PR should not be merged at this time. label May 24, 2020
@mergify
Copy link
Contributor

mergify bot commented May 24, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented May 24, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 86eac6a into master May 24, 2020
@mergify mergify bot deleted the shivlaks/sfn-pass-state-paths branch May 24, 2020 21:11
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 33ddcec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

@rix0rrr rix0rrr Awaiting requested review from rix0rrr

Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Step Functions - Support JSONPath in Pass State Parameters
3 participants
@shivlaks @aws-cdk-automation @nija-at