Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudtrail): create cloudwatch event without needing to create a Trail #8076

Merged
merged 5 commits into from
May 20, 2020
Merged

feat(cloudtrail): create cloudwatch event without needing to create a Trail #8076

merged 5 commits into from
May 20, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented May 19, 2020 •
edited by shivlaks
Loading

closes #6716

@nija-at nija-at requested review from rix0rrr and a team May 19, 2020 14:15
@nija-at nija-at self-assigned this May 19, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 19, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 9d26d00
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks
shivlaks suggested changes May 19, 2020
View reviewed changes
packages/@aws-cdk/aws-cloudtrail/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cloudtrail/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cloudtrail/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-cloudtrail/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cloudtrail/lib/cloudtrail.ts Show resolved Hide resolved
@shivlaks
Apply suggestions from code review
d3b0a70 
Co-authored-by: Shiv Lakshminarayan <shivlaks@amazon.com>
@nija-at nija-at requested a review from shivlaks May 20, 2020 10:26
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d3b0a70
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: da8b30e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at requested a review from a team May 20, 2020 11:48
@mergify
Copy link
Contributor

mergify bot commented May 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented May 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8825a51
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 85d70c3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0567a23 into master May 20, 2020
@mergify mergify bot deleted the nija-at/cloudtrail-onevent branch May 20, 2020 21:35
karupanerura pushed a commit to karupanerura/aws-cdk that referenced this pull request May 22, 2020
@karupanerura
feat(cloudtrail): create cloudwatch event without needing to create a…
8f95e8d 
… Trail (aws#8076)

closes aws#6716
@nija-at nija-at mentioned this pull request May 29, 2020
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks approved these changes

@rix0rrr rix0rrr Awaiting requested review from rix0rrr

Assignees

@nija-at nija-at

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cloudtrail: Also make onCloudTrailEvent a static method
3 participants
@nija-at @aws-cdk-automation @shivlaks