fix(aws-eks): kubectlEnabled: false conflicts with addNodegroup

[pahud]

fix(aws-eks): kubectlEnabled: false conflicts with addNodegroup

This PR allows cluster.addNodegroup() when kubectlEnabled is false

Closes: #7993

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[pahud]

This PR is still failing the test. I am still trying to figure it out.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: e34f8d2
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: f6f0e28
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[pahud]

Hi @eladb

Now according to the test, the test statement will not create

Custom::AWSCDK-EKS-KubernetesResource Cluster/AwsAuth/manifest/Resource
and
AWS::CloudFormation::Stack @aws-cdk--aws-eks.KubectlProvider.NestedStack

    // GIVEN
      const { stack } = testFixture();

      // WHEN
      new eks.Cluster(stack, 'MyCluster', {
        clusterName: 'my-cluster-name',
      });

So we will lose one AssumeRole policy for the KubectlProviderHandlerServiceRole.

Do you think it's safe to simply remove this statement from the test expection?

[eladb]

Do you think it's safe to simply remove this statement from the test expection?

yes

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 030049f
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 5f8a854
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[pahud]

Hi @eladb tests all passed please review and approve again. Thanks.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).