chore: integ test flakiness #8124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
approved these changes
May 21, 2020
Stacks that are being deployed using roles need to be deleted while the role is still present. Our test was deleting the role before the stack was being deleted, and so would fail. This was a race condition due to a missing `await`. Fix both.
eladb
reviewed
May 21, 2020
rix0rrr
force-pushed
the
huijbers/fix-destroy-role
branch
from
ab6b994 to
ce9d478
Compare
eladb
approved these changes
May 21, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
karupanerura
pushed a commit
to karupanerura/aws-cdk
that referenced
this pull request
May 22, 2020
Stacks that are being deployed using roles need to be deleted while the role is still present. Our test was deleting the role before the stack was being deleted, and so would fail. This was a race condition due to a missing `await`. Fix both. Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks that are being deployed using roles need to be deleted while the
role is still present. Our test was deleting the role before the stack
was being deleted, and so would fail.
This was a race condition due to a missing
await.Fix both.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license