feat(cognito): sign in url for a UserPoolDomain #8155
Conversation
Compute the sign in URL from a user pool domain, given a client. The previous defaults on the UserPoolClient created one successfully but was unusable since all of the features were turned off. The defaults have been changed now so that the client created by default works out of the box. BREAKING CHANGE: OAuth flows `authorizationCodeGrant` and `implicitCodeGrant` in `UserPoolClient` are enabled by default. * **cognito:** `callbackUrl` property in `UserPoolClient` is now optional and has a default. * **cognito:** All OAuth scopes in a `UserPoolClient` are now enabled by default.
nija-at
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| /** | ||
| * The URL to the sign in page in this domain using a specific UserPoolClient | ||
| * @param client [disable-awslint:ref-via-interface] the user pool client that the UI will use to interact with the UserPool | ||
| * @param redirectUri the URI to redirect to after sign in. This URI must be one specified in the `callbackUrl` |
There was a problem hiding this comment.
Not too crucial but thought i'd throw it out there:
How about we expose callbackUrls on UserPoolClient so that we can validate the redirectUrl argument here?
There was a problem hiding this comment.
I'll leave that for a future PR. Maybe a community contribution that someone would want to do ;)
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Compute the sign in URL from a user pool domain, given a client.
The previous defaults on the UserPoolClient created one successfully but
was unusable since all of the features were turned off.
The defaults have been changed now so that the client created with the
defaults works out of the box.
BREAKING CHANGE: OAuth flows
authorizationCodeGrantandimplicitCodeGrantinUserPoolClientare enabled by default.callbackUrlproperty inUserPoolClientis nowoptional and has a default.
UserPoolClientare now enabledby default.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license