Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codestar): support the GitHubRepository resource #8209

Merged
merged 21 commits into from
Jun 8, 2020
Merged

feat(codestar): support the GitHubRepository resource #8209

merged 21 commits into from
Jun 8, 2020

Conversation

pahud
Copy link
Contributor

@pahud pahud commented May 26, 2020 •
edited
Loading

feat(codestar): support the GitHubRepository resource

This PR allows to create github repositories with the new GitHubRepository resource

Closes #8210

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 437516d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pahud pahud changed the title feat(codestar): support the GithubRepository resource feat(codestar): support the GitHubRepository resource May 26, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b259508
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 168d3a3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a6be6e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3806972
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3d82997
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85
skinny85 previously requested changes May 27, 2020
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @pahud , thanks for the contribution! Some minor comments inside.

Here's a bigger question for you though: we already use GitHub repositories as input in a few places; mainly, as CodeBuild sources and CodePipeline source actions. How do we make sure that the CodeStar GitHub Repository resource plays nicely with those existing solutions? (Yes,I know this is a tricky question, but I think it needs to be asked nonetheless 🙂).

packages/@aws-cdk/aws-codestar/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-codestar/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codestar/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codestar/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codestar/lib/github.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codestar/package.json Show resolved Hide resolved
packages/@aws-cdk/aws-codestar/package.json Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codestar/test/integ.github.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codestar/test/codestar.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codestar/test/codestar.test.ts Outdated Show resolved Hide resolved
@pahud @skinny85
Update packages/@aws-cdk/aws-codestar/README.md
251b27d 
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
@mergify mergify bot dismissed skinny85’s stale review May 27, 2020 00:29

Pull request has been modified.

@pahud
Copy link
Contributor Author

pahud commented May 27, 2020

@skinny85 I always can learn many good practices from your review. Appreciated! Will update this PR shortly.

@pahud pahud marked this pull request as draft May 27, 2020 00:42
@pahud @skinny85
Update packages/@aws-cdk/aws-codestar/lib/github.ts
40eb81b 
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 40eb81b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 251b27d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 40eb81b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 05562d3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 6cb2f44
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pahud pahud marked this pull request as ready for review May 27, 2020 03:52
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fab739d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5b9107a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5ef9d1c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: eb9ad0e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pahud pahud marked this pull request as draft May 28, 2020 15:19
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 818177d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pahud pahud marked this pull request as ready for review May 28, 2020 23:28
@pahud pahud requested a review from skinny85 May 28, 2020 23:28
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d8367b3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pahud
Copy link
Contributor Author

pahud commented Jun 2, 2020

Hi @skinny85

Please kindly review again. Thanks.

skinny85
skinny85 previously requested changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome @pahud !

Couple of minor comments, and I think you forgot to handle one of the input properties.

packages/@aws-cdk/aws-codestar/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codestar/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codestar/lib/github-repository.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codestar/lib/github-repository.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codestar/lib/github-repository.ts Show resolved Hide resolved
@mergify mergify bot dismissed skinny85’s stale review June 3, 2020 00:17

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: dba74b9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks
shivlaks reviewed Jun 3, 2020
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth mentioning in the README (or elsewhere) that this resource will not be deleted upon the deletion of a CloudFormation stack.

It's not a configurable option AFAIK and will always result in an orphaned repository.

@pahud
Copy link
Contributor Author

pahud commented Jun 3, 2020

I think it's worth mentioning in the README (or elsewhere) that this resource will not be deleted upon the deletion of a CloudFormation stack.

It's not a configurable option AFAIK and will always result in an orphaned repository.

Thanks!! It's worth noting in the README. Just updated.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 118a6ba
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85
skinny85 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks @pahud !

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 0854960
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 02ddab8 into aws:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks left review comments

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support the GithubRepository L2 resource from aws-codestar
4 participants
@pahud @aws-cdk-automation @skinny85 @shivlaks