chore(monocdk): re-do build logic #8234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the monocdk-experiment package adhere to the general flow of having a `build` phase followed by a `package` phase, instead of doing both at the same time. Additionally, using a TypeScript transform to re-write imports instead of doing search and replace. The new implementation still looks only at the ES6-style `import`s, but could be extended to go re-write other kinds of imports if the need arises. This also pre-generates submodule-local configurations for naming, which are not used right now but will become used in a future version of `jsii`. Right now this file is just metadata. Finally, this models the dependencies in the local package, instead of creating a shadow package for publishing. The `yarn gen` script will make sure `bundledDependencies`, `dependencies` and `devDependencies` are properly configured, as well as ensure the correct `nohoist` entries are in the workspace root's `package.json` (so the bundled dependencies are where `npm pack` needs to have them).
RomainMuller
force-pushed
the
rmuller/monocdk
branch
from
f6118c6 to
3c23d6d
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
approved these changes
May 27, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the monocdk-experiment package adhere to the general flow of having
a
buildphase followed by apackagephase, instead of doing both atthe same time.
Additionally, using a TypeScript transform to re-write imports instead
of doing search and replace. The new implementation still looks only at
the ES6-style
imports, but could be extended to go re-write otherkinds of imports if the need arises.
This also pre-generates submodule-local configurations for naming, which
are not used right now but will become used in a future version of
jsii. Right now this file is just metadata.Finally, this models the dependencies in the local package, instead of
creating a shadow package for publishing. The
yarn genscript willmake sure
bundledDependencies,dependenciesanddevDependenciesare properly configured, as well as ensure the correct
nohoistentriesare in the workspace root's
package.json(so the bundled dependenciesare where
npm packneeds to have them).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license