chore(cli): fix security related changes integ test #8274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was passing because (1) the stack contained an incorrect service principal and (2) `--require-approval` was set to `never` by default. This means that the stack was actually deployed but failed, making the test pass. Corrected the service principal, added an expectation to ensure that the stack did not deploy and removed the `--require-approval` CLI option during this test.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
shivlaks
approved these changes
Jun 2, 2020
| @@ -39,6 +39,7 @@ export interface ShellOptions extends child_process.SpawnOptions { | |||
|
|
|||
| export interface CdkCliOptions extends ShellOptions { | |||
| options?: string[]; | |||
| neverRequireApproval?: boolean; | |||
There was a problem hiding this comment.
I prefer if we could avoid the negation in the name (i.e. prefer requireApproval).
In this case its closely tied to the flag we want to set so I don't mind it
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2020
following on from #8274 where a broken integ test that never ran was fixed. A different test for the IAM diff was verifying previously incorrect service principal and we missed updating the expectation. This fixes up the expectations to align to the changes made in #8274 and uses the corrected service principal (ec2.amazonaws.com). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was passing because (1) the stack contained an incorrect service principal
and (2)
--require-approvalwas set toneverby default. This means that the stackwas actually deployed but failed, making the test pass.
Corrected the service principal, added an expectation to ensure that the stack
did not deploy and removed the
--require-approvalCLI option during this test.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license