Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs-patterns): support min and max health percentage in queueprocessingservice #8312

Merged
merged 2 commits into from
Jun 3, 2020
Merged

feat(ecs-patterns): support min and max health percentage in queueprocessingservice #8312

merged 2 commits into from
Jun 3, 2020

Conversation

plastic-karma
Copy link
Contributor

@plastic-karma plastic-karma commented Jun 1, 2020 •
edited by piradeepk
Loading

Add support for min and max health percentage in queueprocessingservice (#8277)

Tested with yarn build+test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 855c765
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: e3d9a72
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f2e0c4e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5b78852
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@SomayaB SomayaB changed the title adding min and max halth percentage to queue-processing fargate service feat(ecs-patterns): adding min and max halth percentage to queue-processing fargate service Jun 2, 2020
@SomayaB SomayaB added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Jun 2, 2020
@hencrice hencrice changed the title feat(ecs-patterns): adding min and max halth percentage to queue-processing fargate service feat(ecs-patterns): adding min and max health percentage to queue-processing service Jun 2, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5f41f61
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ea80fb8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@hencrice hencrice requested a review from piradeepk June 3, 2020 21:46
@hencrice
Copy link
Contributor

hencrice commented Jun 3, 2020

LGTM. @pkandasamy91 Could you take another pass?

piradeepk
piradeepk approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 💯 Thanks for adding these properties @plastic-karma!

@piradeepk piradeepk requested a review from hencrice June 3, 2020 22:35
@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@piradeepk piradeepk changed the title feat(ecs-patterns): adding min and max health percentage to queue-processing service feat(ecs-patterns): adding min and max health percentage to queueprocessingservice Jun 3, 2020
@piradeepk piradeepk changed the title feat(ecs-patterns): adding min and max health percentage to queueprocessingservice feat(ecs-patterns): support min and max health percentage in queueprocessingservice Jun 3, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 0452e97
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6da564d into aws:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piradeepk piradeepk piradeepk approved these changes

@hencrice hencrice Awaiting requested review from hencrice

Assignees

@uttarasridhar uttarasridhar

Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@plastic-karma @aws-cdk-automation @hencrice @piradeepk @uttarasridhar @SomayaB