Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(aws-cdk): add maven wrapper to java template" #833

Merged
merged 3 commits into from
Oct 8, 2018
Merged

Revert "feat(aws-cdk): add maven wrapper to java template" #833

merged 3 commits into from
Oct 8, 2018

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Oct 2, 2018

Reverts #811

@rix0rrr rix0rrr requested review from eladb and RomainMuller October 2, 2018 15:18
RomainMuller
RomainMuller approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to have a descriptive commit message.

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Oct 5, 2018

Make sure to have a descriptive commit message.

Have any opinions/suggestions? Is our CHANGELOG tool going to detect this?

@eladb eladb merged commit d17911e into master Oct 8, 2018
@eladb eladb deleted the revert-811-feat-add-mvnw branch October 8, 2018 07:37
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rix0rrr @RomainMuller @eladb @NGL321