Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-ec2): add support for UDP to SecurityGroupRule #835

Merged
merged 5 commits into from
Oct 3, 2018
Merged

feat(aws-ec2): add support for UDP to SecurityGroupRule #835

merged 5 commits into from
Oct 3, 2018

Commits on Oct 3, 2018

  1. Add support for UDP to ec2.SecurityGroupRule

    @ChintanRaval
    ChintanRaval committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    f332c82 View commit details
    Browse the repository at this point in the history

  2. code review feedback - ensure all UDP related IPortRange implmentatio… 

    …ns output context upon invoking toString
    @ChintanRaval
    ChintanRaval committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    a4918e7 View commit details
    Browse the repository at this point in the history

  3. include protocol in toString methods of both TCP and UDP implementati… 

    …ons of IPortRange
    @ChintanRaval
    ChintanRaval committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    d072dc4 View commit details
    Browse the repository at this point in the history

  4. Revert "include protocol in toString methods of both TCP and UDP impl… 

    …ementations of IPortRange"

This reverts commit d072dc4.
    @ChintanRaval
    ChintanRaval committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    33ed772 View commit details
    Browse the repository at this point in the history

  5. ensure UdpPortFromAttribute.toString outputs context to avoid similar… 

    …ity with corresponding TCP-type
    @ChintanRaval
    ChintanRaval committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    81cd079 View commit details
    Browse the repository at this point in the history