-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eks): can't define a cluster with multiple Fargate profiles #8374
Conversation
Adds a DependsOn Fargate profile resources when more than one Fargate profiles exists on the same cluster. fixes #6084
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rather implement this without prepare
and also support profiles that are not a direct child of the cluster.
The way I would approach this is by adding an internal method to Cluster (starts with an underscore and has an @internal) annotation) which is called by the FargateProfile class itself during initialization, “registers” the profile on the cluster and perhaps returns the existing profile list (could be a separate api, doesn’t need to be internal).
This will allow each profile to “chain” itself to the last one.
… at FargateProfile creation.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Adds a DependsOn Fargate profile resources when more than one Fargate profiles
exists on the same cluster.
fixes #6084
Tested via:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license