Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(elbv2): addAction ignores conditions #8385

Merged
merged 3 commits into from
Jun 5, 2020
Merged

fix(elbv2): addAction ignores conditions #8385

merged 3 commits into from
Jun 5, 2020

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Jun 4, 2020

Elastic Load Balancer's ApplicationListener.addAction does not pass on conditions array to ApplicationListenerRule.

This PR adds a line that passes on the conditions in the addAction function.

fixes #8328

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@NetaNir NetaNir requested review from NetaNir and rix0rrr June 4, 2020 21:04
@NetaNir NetaNir self-assigned this Jun 4, 2020
@kaizencc kaizencc changed the title fix(elbv2): addAction ignores conditions array fix(elbv2): addAction ignores conditions Jun 4, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: cc08440
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 86f5b12
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rix0rrr
rix0rrr approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Thanks for the fix! <3

@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d20f656
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 729cc0b into aws:master Jun 5, 2020
@kaizencc kaizencc deleted the request branch June 5, 2020 13:10
@danilo-valente danilo-valente mentioned this pull request Aug 12, 2020
Closed
njlynch added a commit that referenced this pull request Aug 24, 2020
@njlynch
fix(elasticloadbalancingv2): imported listener ignores conditions att…
7702785 
…ribute

New conditions attribute usage was fixed in #8385 for owned listeners, but
missed imported listeners.

fixes #9262
fixes #9320
fixes #9643
@njlynch njlynch mentioned this pull request Aug 24, 2020
Merged
mergify bot pushed a commit that referenced this pull request Aug 24, 2020
@njlynch
fix(elasticloadbalancingv2): imported listener ignores conditions att…
1c9b733 
…ribute (#9939)

New conditions attribute usage was fixed in #8385 for owned listeners, but
missed imported listeners.

fixes #9262
fixes #9320
fixes #9643


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@NetaNir NetaNir Awaiting requested review from NetaNir

Assignees

@NetaNir NetaNir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

elbv2.ApplicationListener.addAction ignores conditions array
4 participants
@kaizencc @aws-cdk-automation @rix0rrr @NetaNir