fix(secretsmanager): rebased https://github.com/aws/aws-cdk/pull/7896 #8442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get the last 64 chars of the `uniqueId`. See aws#7885 (comment). Closes aws#7885
ahammond
changed the title
ahammond
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@jogold updated his PR. closing this one. |
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2020
Get the last 64 chars of the `uniqueId`. See #7885 (comment). Closes #7885 Closes #8442 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As near as I can see, this is the only code that's specific to the original PR from @jogold
fix(secretsmanager): rotation function name exceeds 64 chars
Get the last 64 chars of the
uniqueId.See #7885 (comment).
Closes #7885
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license