fix(core): incorrect temp directory when bundling assets #8469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `os.tmpdir()` built-in doesn't return the real path when the returned path is a symlink. Add a `FileSystem.tmpdir` that wraps `os.tmpdir()` in a `fs.realpathSync()` and caches the result. Fixes aws#8465
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
previously requested changes
Jun 10, 2020
| /** | ||
| * The real path of the system temp directory | ||
| */ | ||
| public static get tmpdir(): string { |
There was a problem hiding this comment.
Instead (or in addition) to this, can we add FileSystem.mkdtemp('suffix-')? It's such a common case.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Jun 10, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
os.tmpdir()built-in doesn't return the real path when thereturned path is a symlink.
Add a
FileSystem.tmpdirthat wrapsos.tmpdir()in afs.realpathSync()and caches the result.Add a
FileSystem.mkdtemp()to create temp directories inthe system temp directory.
Fixes #8465
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license