Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): efs filesystems #8602
feat(lambda): efs filesystems #8602
Changes from 58 commits
25762f4
16e1311
cac456f
5b76922
5f85413
0b56916
484caba
e77d4a6
1b27ade
4deb43d
3a1e8fd
53492f0
64af74f
c534ff0
b3c503a
73d3d22
e756770
0bdbca6
1687560
f1d25b6
52d1f2d
aec9b6e
c43d6f0
7b87dd4
035affa
2e8fcde
c3b5aee
3f9f709
6e22e90
3a5cd81
7de5399
0595cd9
46065b3
1e5afa1
93fb996
07435dd
7d855f2
d246979
460ff7a
764210d
3298ce7
740dcd8
94b64c1
4ce6567
1bea0cf
d37cead
c9c03a0
fa1679a
0065bfa
2114987
7fb7ac8
f1bd125
db34025
44cb692
f1fb5fa
3cb9b0d
2845c6d
f83a571
956f2b0
2434b57
f93c45e
4e553d9
20563a3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unnecessary future proofing.. If only a single file system is allowed, then why do we need the property to be
filesystems
? Shall we change it tofilesystem
? In the future if we want to add additional filesystems, we can either deprecate the singular property or addadditionalFileSystems
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Let me revise it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @eladb
It's
filesystem
now.And, to even scope down the required iam policies according to the doc, I changed
managedPolicies
topolicies
and bake the required policy statements like this in thefromEfsAccessPoint
Let me know if it looks better now.