- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4.3k
feat(cfn-include): add support for retrieving parameter objects #8658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            35 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      db60c27
              
                doc: added slack link to readme
              
              
                comcalvi 5924f3b
              
                Merge branch 'master' into master
              
              
                comcalvi f0c85a3
              
                Update README.md
              
              
                comcalvi f37e60e
              
                Merge branch 'master' into master
              
              
                mergify[bot] 83ed743
              
                Merge branch 'master' of https://github.com/aws/aws-cdk
              
              
                comcalvi c6664af
              
                added support for Fn::Select, Fn::FindInMap, Fn::Cidr, Fn::GetAZs, Fn…
              
              
                comcalvi d0f64d2
              
                added support for the 'Fn::Transform' cloudformation intrinsic function.
              
              
                comcalvi d69e46d
              
                added support for the Fn::Base64 Intrinsic Function
              
              
                comcalvi df1446a
              
                tested more complex combinations of conditional and non-conditional i…
              
              
                comcalvi 132cb4d
              
                fixed linter issues
              
              
                comcalvi ae7c570
              
                implmented Adam's requests and fixed additional linter issues
              
              
                comcalvi 7ca707e
              
                updated README to reflect the newly supported cloudformation functions
              
              
                comcalvi 63c27a7
              
                removed quotes from the type of Transform's parameter argument, modif…
              
              
                comcalvi 4179271
              
                fixed teseting issue related to Fn::Select
              
              
                comcalvi 117ae63
              
                Merge branch 'master' into CfnFunctions
              
              
                comcalvi dbb9ef8
              
                fixing merge conflicts
              
              
                comcalvi bdab761
              
                Merge branch 'master' of https://github.com/aws/aws-cdk
              
              
                comcalvi d390580
              
                Merge branch 'master' of https://github.com/aws/aws-cdk into CfnFunct…
              
              
                comcalvi 14a0d64
              
                merge conflict resolution
              
              
                comcalvi dfb42b9
              
                Merge branch 'CfnFunctions' of github.com:comcalvi/aws-cdk into CfnFu…
              
              
                comcalvi 9f1b2d9
              
                Merge branch 'master' of https://github.com/aws/aws-cdk into CfnFunct…
              
              
                comcalvi 4c9d1ec
              
                fixed typo in condition name
              
              
                comcalvi e15c187
              
                Merge branch 'CfnFunctions'
              
              
                comcalvi 82c4317
              
                Merge branch 'master' of https://github.com/aws/aws-cdk
              
              
                comcalvi 42c0228
              
                removed parameters from _toCloudFormation()
              
              
                comcalvi 6a2df1e
              
                added support for parameters in templates
              
              
                comcalvi 43198b7
              
                fixed merge conflict
              
              
                comcalvi cd27ff6
              
                updated documentation
              
              
                comcalvi 1e72465
              
                updated readme
              
              
                comcalvi 070f902
              
                incorporated adam's comments
              
              
                comcalvi b10a1ed
              
                fixed spacing
              
              
                comcalvi f07037b
              
                Update no longer up-to-date comments in CfnInclude's constructor
              
              
                skinny85 c01cc4a
              
                Make string literals consistent
              
              
                skinny85 a45f168
              
                Move the loading of the test file to the 'then' part of the test
              
              
                skinny85 4c95ced
              
                Merge branch 'master' into CfnParams
              
              
                mergify[bot] File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            47 changes: 47 additions & 0 deletions
          
          47 
        
  packages/@aws-cdk/cloudformation-include/test/test-templates/bucket-with-parameters.json
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| { | ||
| "Parameters": { | ||
| "BucketName": { | ||
| "Default": "MyS3Bucket", | ||
| "AllowedPattern": "^[a-zA-Z0-9]*$", | ||
| "ConstraintDescription": "a string consisting only of alphanumeric characters", | ||
| "Description": "The name of your bucket", | ||
| "MaxLength": "10", | ||
| "MinLength": "1", | ||
| "Type": "String", | ||
| "NoEcho": "true" | ||
| }, | ||
| "CorsMaxAge": { | ||
| "Default": "3", | ||
| "Description": "the time in seconds that a browser will cache the preflight response", | ||
| "MaxValue": "300", | ||
| "MinValue": "0", | ||
| "Type": "Number", | ||
| "NoEcho": "true" | ||
| } | ||
| }, | ||
| "Resources": { | ||
| "Bucket": { | ||
| "Type": "AWS::S3::Bucket", | ||
| "Properties": { | ||
| "BucketName": { | ||
| "Ref": "BucketName" | ||
| }, | ||
| "CorsConfiguration": { | ||
| "CorsRules": [{ | ||
| "AllowedMethods": [ | ||
| "GET", | ||
| "POST" | ||
| ], | ||
| "AllowedOrigins": [ | ||
| "origin1", | ||
| "origin2" | ||
| ], | ||
| "MaxAge": { | ||
| "Ref": "CorsMaxAge" | ||
| } | ||
| }] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.