Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iam): cannot import service role with a principal in its path #8692

Merged
merged 10 commits into from
Jul 8, 2020
Merged

fix(iam): cannot import service role with a principal in its path #8692

merged 10 commits into from
Jul 8, 2020

Conversation

ThomasSteinbach
Copy link
Contributor

@ThomasSteinbach ThomasSteinbach commented Jun 23, 2020 •
edited by skinny85
Loading

Fixes #8691

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@ThomasSteinbach
fix aws#8691 by identifying correct role name
0b47eef 
I am no typescript programmer but I think this change could solve aws#8691
@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@ThomasSteinbach ThomasSteinbach changed the title fix #8691 by identifying correct role name fix: #8691 by identifying correct role name Jun 23, 2020
@ThomasSteinbach
Copy link
Contributor Author

It would be nice, if some typescript/cdk programmer could do this fix right.

@ThomasSteinbach ThomasSteinbach mentioned this pull request Jun 23, 2020
Closed
@skinny85
Copy link
Contributor

Thanks for the fix @ThomasSteinbach ! I've updated your PR, let's see if the CI build passes.

@skinny85 skinny85 changed the title fix: #8691 by identifying correct role name fix(iam): could not import service role with a principal in its name Jun 23, 2020
@ThomasSteinbach
Copy link
Contributor Author

Cool, thanx @skinny85

@ThomasSteinbach
Copy link
Contributor Author

ThomasSteinbach commented Jun 24, 2020 •
edited
Loading

Hi @rix0rrr , could you please review or assign so. to review the changes made by skinny85 and me? It looks like skinny85 knows what he is doing, so it shouldn't be a great hassle :)

@dvonessen
Copy link

I need this too, so that we can migrate from AWS CFN to CDK.

@rix0rrr rix0rrr changed the title fix(iam): could not import service role with a principal in its name fix(iam): cannot import service role with a principal in its path Jul 8, 2020
@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 264eff6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 55eb7d7 into aws:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-iam): role contains invalid characters for service roles
5 participants
@ThomasSteinbach @skinny85 @dvonessen @aws-cdk-automation @rix0rrr