chore(eks): kubectl 1.16.8-eks-e16311, aws-cli 1.18.86, helm 3.2.4 #8739
Conversation
|
Hi @eladb , I am ready. |
eladb
changed the title
eladb
changed the title
| * create namespace if not exist | ||
| * @default False | ||
| */ | ||
| readonly createNamespace?: boolean; |
There was a problem hiding this comment.
Sorry but this should be a separate PR :-)
[think about the changelog entry :-)]
I added comments on the namespace change as well here so it's PR can start from there
| namespace = props.get('Namespace', None) | ||
| repository = props.get('Repository', None) | ||
| values_text = props.get('Values', None) | ||
| role_arn = props['RoleArn'] |
There was a problem hiding this comment.
Please avoid aesthetic changes, those make the code review harder.
Any reason spacing was changed?
| '--kubeconfig', kubeconfig | ||
| ]) | ||
| subprocess.check_call(['aws', 'eks', 'update-kubeconfig', | ||
| '--role-arn', role_arn, |
| @@ -14,8 +14,11 @@ class EksClusterStack extends TestStack { | |||
| assumedBy: new iam.AccountRootPrincipal(), | |||
| }); | |||
|
|
|||
| const vpc = new ec2.Vpc(this, 'Vpc', { maxAzs: 3, natGateways: 1}); | |||
There was a problem hiding this comment.
-
add a comment explaining why this is needed
-
style:
| const vpc = new ec2.Vpc(this, 'Vpc', { maxAzs: 3, natGateways: 1}); | |
| const vpc = new ec2.Vpc(this, 'Vpc', { maxAzs: 3, natGateways: 1 }); |
| * create namespace if not exist | ||
| * @default False | ||
| */ | ||
| readonly createNamespace?: boolean; |
There was a problem hiding this comment.
Feels like it makes more sense for this to be enabled by default, no? What are the implications?
pahud
changed the title
|
I'm still working on the integ tests. Got lambda timeout error. description in #8773 (comment) |
|
Merged just for you! |
|
Hi @eladb this PR should be ready now. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…ws#8739) - bump aws-lambda-layer-kubectl [2.0.0](https://github.com/aws-samples/aws-lambda-layer-kubectl/releases/tag/2.0.0) with kubectl v1.16.8-eks-e16311, awscli 1.18.86 and helm 3.2.4 - update the helm repo of the kubernetes-dashboard in the integ test to `https://kubernetes.github.io/dashboard/` from [Helm Hub](https://hub.helm.sh/charts/k8s-dashboard) as `https://kubernetes-charts.storage.googleapis.com` has been deprecated ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
with kubectl v1.16.8-eks-e16311, awscli 1.18.86 and helm 3.2.4
https://kubernetes.github.io/dashboard/from Helm Hub ashttps://kubernetes-charts.storage.googleapis.comhas been deprecatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license