Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk): Add support for UseOnlineResharding with UpdatePolicies. #881

Merged
merged 2 commits into from
Oct 10, 2018
Merged

feat(cdk): Add support for UseOnlineResharding with UpdatePolicies. #881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d04462
feat(cdk): Add support for UseOnlineResharding with UpdatePolicies.
Oct 9, 2018
3a9e3ce
Update test to be independent
Oct 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/@aws-cdk/cdk/lib/cloudformation/resource-policy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,12 @@ export interface UpdatePolicy {
*/
autoScalingScheduledAction?: AutoScalingScheduledAction;

/**
* To modify a replication group's shards by adding or removing shards, rather than replacing the entire
* AWS::ElastiCache::ReplicationGroup resource, use the UseOnlineResharding update policy.
*/
useOnlineResharding?: boolean;

}

/**
Expand Down
24 changes: 22 additions & 2 deletions packages/@aws-cdk/cdk/test/cloudformation/test.resource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export = {

r1.options.creationPolicy = { autoScalingCreationPolicy: { minSuccessfulInstancesPercent: 10 } };
// tslint:disable-next-line:max-line-length
r1.options.updatePolicy = { autoScalingScheduledAction: { ignoreUnmodifiedGroupSizeProperties: false }, autoScalingReplacingUpdate: { willReplace: true } };
r1.options.updatePolicy = { autoScalingScheduledAction: { ignoreUnmodifiedGroupSizeProperties: false }, autoScalingReplacingUpdate: { willReplace: true }};
r1.options.deletionPolicy = DeletionPolicy.Retain;

test.deepEqual(stack.toCloudFormation(), {
Expand All @@ -180,7 +180,7 @@ export = {
CreationPolicy: { AutoScalingCreationPolicy: { MinSuccessfulInstancesPercent: 10 } },
UpdatePolicy: {
AutoScalingScheduledAction: { IgnoreUnmodifiedGroupSizeProperties: false },
AutoScalingReplacingUpdate: { WillReplace: true }
AutoScalingReplacingUpdate: { WillReplace: true },
},
DeletionPolicy: 'Retain'
}
Expand All @@ -190,6 +190,26 @@ export = {
test.done();
},

'update policies UseOnlineResharding flag'(test: Test) {
const stack = new Stack();
const r1 = new Resource(stack, 'Resource', { type: 'Type' });

r1.options.updatePolicy = { useOnlineResharding: true };

test.deepEqual(stack.toCloudFormation(), {
Resources: {
Resource: {
Type: 'Type',
UpdatePolicy: {
UseOnlineResharding: true,
},
}
}
});

test.done();
},

'metadata can be set on a resource'(test: Test) {
const stack = new Stack();
const r1 = new Resource(stack, 'Resource', { type: 'Type' });
Expand Down