-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): Java init template compiles apps before trying to run them #8850
Conversation
@RomainMuller Can you approve this, assuming I've done it the best way? I'd like to get it into a release soon; it'll let me remove lots of build instructions from the Dev Guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reckon this can be achieved without shelling out twice (tested locally and achieved the expected result).
Yeah that definitely is a sweet, sweet simplification! Thanks for looking into that!! |
@RomainMuller Ready for another look. |
I thought about trying it in one command but was afraid it might still try to run the app if the compile failed. On reflection, even it did that, you're just going to get the same result you already had, so no harm. And avoiding spinning up the JVM twice seems like a definite win. |
@jerry-aws nice! this is a great simplification. were you able to run the integ tests successfully as well? |
Annotated with do-not-merge so you can consider @shivlaks' comment. You can remove the label when you're ready to merge in. |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
I was able to run the integ tests successfully after a bit of effort. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The TypeScript and C# init templates use commands that compile the code before running it to prevent the user from forgetting. This adds the same functionality to the Java init template.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license