fix(eks): kubectl resources fail before fargate profiles are created #8855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Fargate profile is being created, the Kubernetes API server in EKS sometimes rejects requests. This means that kubectl-related resources such as KubernetesResources Helm charts may fail during deployment. To address this, we add a "barrier resource" (in the form of an SSM parameter) which waits for all fargate profiles to be created before allowing kubectl resources to continue. This is done by the barrier taking a dependency on all FargateProfile resources and all kubectl resources taking a dependency on the barrier. Fixes #8854 This commit also fixes #8574 by adding `iam:ListAttachedRolePolicies` to the cluster's creation role IAM policy.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
iliapolo
reviewed
Jul 2, 2020
| provider = new KubectlProvider(this.stack, uid); | ||
|
|
||
| // allow the kubectl provider to assume the cluster creation role. | ||
| this._clusterResource.addTrustedRole(provider.role); |
There was a problem hiding this comment.
You moved this inside the singleton creation, but won't this mean that if two clusters are defined on the same stack, one of them wont have the trusted role?
There was a problem hiding this comment.
Yes, nice catch! Let me add a test and fix
|
Oops... Accidentally merged this into benisrae/improve-cr-errors. |
|
New PR #8859 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Fargate profile is being created, the Kubernetes API server in EKS sometimes rejects requests. This means that kubectl-related resources such as KubernetesResources and Helm charts may fail during deployment.
To address this, we add a "barrier resource" (in the form of an SSM parameter) which waits for all fargate profiles to be created before allowing kubectl resources to continue. This is done by the barrier taking a dependency on all FargateProfile resources and all kubectl resources taking a dependency on the barrier.
Fixes #8854
This commit also fixes #8574 by adding
iam:ListAttachedRolePoliciesto the cluster's creation role IAM policy.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license