Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(appsync): reorganize code base to improve readability #8933

Merged
merged 5 commits into from
Jul 8, 2020

Conversation

BryanPan342
Copy link
Contributor

[ISSUE]
aws-appsync library only had one file to host all the code. Hard to read and navigate because close to 2000 lines.

[APPROACH]
Segmented in the following manner:

  • Data Sources
  • Resolvers
  • Keys
  • GraphQL
  • Mapping Templates

[NOTE]
File names and contents are subject to change as I continue to add to this construct.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@BryanPan342 BryanPan342 self-assigned this Jul 8, 2020
@BryanPan342 BryanPan342 added the @aws-cdk/aws-appsync Related to AWS AppSync label Jul 8, 2020
packages/@aws-cdk/aws-appsync/lib/key.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed shivlaks’s stale review July 8, 2020 16:06

Pull request has been modified.

Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely makes it much easier to navigate. Thanks! 🙏

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d464ed1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1bc8dfa into aws:master Jul 8, 2020
@skinny85
Copy link
Contributor

skinny85 commented Jul 9, 2020

Uhm. In general, we don't name files in camelCase. We use dash-case. So these files should be called data-source.ts, mapping-template.ts, etc.

@BryanPan342
Copy link
Contributor Author

Uhm. In general, we don't name files in camelCase. We use dash-case. So these files should be called data-source.ts, mapping-template.ts, etc.

ah yes sorry! Code base is in camelCase so forgot. Will make a PR to fix it.

@BryanPan342 BryanPan342 deleted the appsync-reorganize branch September 8, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-appsync Related to AWS AppSync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants