Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: upgrade to constructs 4.x #8962

Closed
wants to merge 46 commits into from
Closed

POC: upgrade to constructs 4.x #8962

wants to merge 46 commits into from

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jul 9, 2020

This branch includes the work required to remove the constructs compatibility layer from the AWS CDK codebase.
See RFC: aws/aws-cdk-rfcs#195


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Jul 9, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 9, 2020
@eladb eladb marked this pull request as draft July 9, 2020 18:43
@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8ed2437
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold
Copy link
Contributor

jogold commented Jul 14, 2020

@eladb took a look at the new AssetStaging class, if outdir is known at construction time we can directly bundle in it (which allows the optimization requested by #8882) and we don't need to moveSync at all (non bundled assets would still be copied if staging is enabled).

For another PR after this one?

cc @misterjoshua

@eladb
Copy link
Contributor Author

eladb commented Jul 14, 2020

@eladb took a look at the new AssetStaging class, if outdir is known at construction time we can directly bundle in it (which allows the optimization requested by #8882) and we don't need to moveSync at all (non bundled assets would still be copied if staging is enabled).

For another PR after this one?

cc @misterjoshua

Love it. Yes, I am hoping to back port most of this into the v1.x line and we'll be able to apply that there. Stay tuned.

@eladb eladb closed this Jul 16, 2020
@rix0rrr rix0rrr deleted the benisrae/constructs-4.x branch April 12, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants