Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(glue): default data location for tables is the root of the bucket #8999

Merged
merged 2 commits into from
Jul 13, 2020
Merged

feat(glue): default data location for tables is the root of the bucket #8999

merged 2 commits into from
Jul 13, 2020
+26 −24

Conversation

DerkSchooltink
Copy link
Contributor

@DerkSchooltink DerkSchooltink commented Jul 10, 2020 •
edited by iliapolo
Loading

Fixes #8472

BREAKING CHANGE: The default location of glue data will be the root of an s3 bucket, instead of /data

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@DerkSchooltink DerkSchooltink force-pushed the DerkSchooltink/set-s3Prefix-emtpy-string branch from a0363a2 to 04ddd5d Compare July 10, 2020 13:32
@iliapolo iliapolo changed the title feat(glue): implement empty string as s3Prefix feat(glue): default data location for tables is the root of the bucket Jul 11, 2020
iliapolo
iliapolo previously requested changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Notice you also have a conflict in a test file...

We just recently switched to using jest: #8862

packages/@aws-cdk/aws-glue/lib/table.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-glue/lib/table.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-glue/README.md Outdated Show resolved Hide resolved
DerkSch added 2 commits July 13, 2020 10:43
@DerkSch
feat(glue): implement empty string as s3Prefix
ac92594 
fixes aws#8472

BREAKING CHANGE: the default location of glue data will be the root of an s3 bucket, instead of /data
@DerkSch
feat(glue): implement empty string as s3Prefix
418027e 
fixes aws#8472

BREAKING CHANGE: the default location of glue data will be the root of an s3 bucket, instead of /data
@DerkSchooltink DerkSchooltink force-pushed the DerkSchooltink/set-s3Prefix-emtpy-string branch from 04ddd5d to 418027e Compare July 13, 2020 08:45
@mergify mergify bot dismissed iliapolo’s stale review July 13, 2020 08:46

Pull request has been modified.

@DerkSchooltink
Copy link
Contributor Author

Just a sanity check: this introduces a breaking change for people relying on the default s3Prefix that points to /data. I've mentioned this in the description of this PR, is this sufficient communication to make clear something breaking has been introduced? @iliapolo

@iliapolo
Copy link
Contributor

@DerkSchooltink Yes. The breaking change notice will appear in our release notes and changelog 👍

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 418027e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 28949bd into aws:master Jul 13, 2020
curtiseppel pushed a commit to curtiseppel/aws-cdk that referenced this pull request Aug 11, 2020
@DerkSchooltink
feat(glue): default data location for tables is the root of the bucket (
7c7f5c1 
aws#8999)

Fixes aws#8472

BREAKING CHANGE: The default location of glue data will be the root of an s3 bucket, instead of `/data`

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliapolo iliapolo iliapolo approved these changes

Assignees

@iliapolo iliapolo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default data location for AWS Glue tables
4 participants
@DerkSchooltink @iliapolo @aws-cdk-automation @DerkSch