chore: move jest-junit dependency to top-level
#9004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`"jest-junit"` is a new dependency for all packages, used as a Jest reporter in the default Jest config located in `cdk-build-tools`. `jest-junit` was added as a dependency to `cdk-build-tools`, but when resolving reporters Jest starts resolving from the *package under test*. That means that `jest-junit` should be a `devDependency` for every individual package; or more easily: add the dependency to the root of the repository so that it is automatically in scope for every package inside it. It used to accidentally work before this change, because the dependency hoisting performed by Yarn moved the dependency up to the root of the tree where it would be found by the jest run.
NetaNir
approved these changes
Jul 10, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"jest-junit"is a new dependency for all packages, used as a Jest reporterin the default Jest config located in
cdk-build-tools.jest-junitwas added as a dependency tocdk-build-tools, but whenresolving reporters Jest starts resolving from the package under test.
That means that
jest-junitshould be adevDependencyfor everyindividual package; or more easily: add the dependency to the root of
the repository so that it is automatically in scope for every package
inside it.
It used to accidentally work before this change, because the dependency
hoisting performed by Yarn moved the dependency up to the root of the
tree where it would be found by the jest run.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license