fix(lambda-nodejs): parcel tries to install @babel/core #9067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Parcel cannot find `@babel/core` in the search paths for node modules it tries to install it. This overwrites the lock file and `node_modules`. Add the `--no-autoinstall` flag to prevent Parcel from installing any missing dependency and switch to a local install in the Docker image at the root (`/`) of the filesystem. This way all dependencies in `/node_modules` will be in the search paths of `/asset-input`. This was not detected in this repo or in the init template because `@babel/core` is a dependency of `jest`. Closes aws#9032
eladb
approved these changes
Jul 16, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
curtiseppel
pushed a commit
to curtiseppel/aws-cdk
that referenced
this pull request
Aug 11, 2020
When Parcel cannot find `@babel/core` in the search paths for node modules it tries to install it. This overwrites the lock file and `node_modules`. Add the `--no-autoinstall` flag to prevent Parcel from installing any missing dependency and switch to a local install in the Docker image at the root (`/`) of the filesystem. This way all dependencies in `/node_modules` will be in the search paths of `/asset-input`. This was not detected in this repo or in the init template because `@babel/core` is a dependency of `jest`. Closes aws#9032 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Parcel cannot find
@babel/corein the search paths for nodemodules it tries to install it. This overwrites the lock file and
node_modules.Add the
--no-autoinstallflag to prevent Parcel from installing anymissing dependency and switch to a local install in the Docker image at
the root (
/) of the filesystem. This way all dependencies in/node_moduleswill be in the search paths of/asset-input.This was not detected in this repo or in the init template because
@babel/coreis a dependency ofjest.Closes #9032
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license