Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigateway): configure endpoint types on SpecRestApi #9068

Merged
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
dd9f704
feat(apigateway) adding the ability to set the endpoint configuration…
IsmaelMartinez Jul 14, 2020
00c3ce4
feat (apigateway): adding the ability for the endpoint configuration …
IsmaelMartinez Jul 14, 2020
8cd4b85
pr adding initial integration test. WIP still need to add the actual …
IsmaelMartinez Jul 14, 2020
97326bc
pr adding integration test
IsmaelMartinez Jul 14, 2020
7e6a4a8
minor documentation renaming to follow the pattern from the previous …
IsmaelMartinez Jul 14, 2020
88233ac
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 14, 2020
4c4caf6
changing the name for the private api gateway integration test
IsmaelMartinez Jul 15, 2020
b63a0e2
Merge branch 'ismaelmartinez/add-endpointconfiguration-for-openapi3' …
IsmaelMartinez Jul 15, 2020
62c6832
updating integration tests after doing a test run in local
IsmaelMartinez Jul 16, 2020
85ac49c
Trying removing the 'expected' integration test as I can't see what i…
IsmaelMartinez Jul 16, 2020
7c2bbc0
WIP reading the integration test file
IsmaelMartinez Jul 16, 2020
2756fee
wip: trying to workout the deployment ids for integration tests from …
IsmaelMartinez Jul 16, 2020
f327d67
removing the metatadata information from the integration test
IsmaelMartinez Jul 16, 2020
51adf34
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 16, 2020
43ff752
PR changes.
IsmaelMartinez Jul 16, 2020
7a097a1
Merge branch 'ismaelmartinez/add-endpointconfiguration-for-openapi3' …
IsmaelMartinez Jul 16, 2020
5fe131c
adding an starting underscore to the new internal function
IsmaelMartinez Jul 16, 2020
dc6f5ec
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 16, 2020
0bdf82e
Adding missing trailing comma in integration tests
IsmaelMartinez Jul 16, 2020
2727182
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 16, 2020
85092ad
removing tailing spaces
IsmaelMartinez Jul 16, 2020
6d3d066
Merge branch 'ismaelmartinez/add-endpointconfiguration-for-openapi3' …
IsmaelMartinez Jul 16, 2020
dfd0be0
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 16, 2020
b5755a8
wip: removing package-lock.json file.
IsmaelMartinez Jul 16, 2020
c54fd16
Merge branch 'ismaelmartinez/add-endpointconfiguration-for-openapi3' …
IsmaelMartinez Jul 16, 2020
ee7dda7
reverting yarn and package unintended changes
IsmaelMartinez Jul 16, 2020
7c03d7d
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 16, 2020
c0e65ab
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 16, 2020
44618d9
pr: documentation and testing changes on the back of @nija-at review
IsmaelMartinez Jul 17, 2020
a0a273e
fixing eslint issues
IsmaelMartinez Jul 17, 2020
18e98ab
eslint fixes
IsmaelMartinez Jul 17, 2020
7fe8f6b
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 17, 2020
d667b6a
move eslint fixes
IsmaelMartinez Jul 17, 2020
71b97ab
hopefully last eslint fixes
IsmaelMartinez Jul 17, 2020
670056c
fix integration test. Id changed
IsmaelMartinez Jul 17, 2020
4a6d1d8
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 19, 2020
d0bcfd9
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 20, 2020
688b3b2
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 20, 2020
62f8fe7
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 21, 2020
279df8c
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 21, 2020
99608de
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 21, 2020
e1c638e
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 23, 2020
ea34bd3
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 24, 2020
e7b18f9
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 27, 2020
10cedac
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 28, 2020
4ebc527
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 28, 2020
f03fe62
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Jul 30, 2020
671dd0a
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Aug 3, 2020
6337b1a
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
IsmaelMartinez Aug 3, 2020
640b142
modiry readme not to have a long line description
IsmaelMartinez Aug 4, 2020
4480b57
Update packages/@aws-cdk/aws-apigateway/README.md
IsmaelMartinez Aug 4, 2020
ea29348
Adding endpoint configuration to the table of contents
IsmaelMartinez Aug 4, 2020
efa3b94
removing integration tests
IsmaelMartinez Aug 4, 2020
80876ec
Update packages/@aws-cdk/aws-apigateway/lib/restapi.ts
IsmaelMartinez Aug 4, 2020
19ea67d
Update packages/@aws-cdk/aws-apigateway/lib/restapi.ts
IsmaelMartinez Aug 4, 2020
0af5923
Update packages/@aws-cdk/aws-apigateway/lib/restapi.ts
IsmaelMartinez Aug 4, 2020
d224d73
Update packages/@aws-cdk/aws-apigateway/README.md
Aug 4, 2020
d165bba
Merge branch 'master' into ismaelmartinez/add-endpointconfiguration-f…
mergify[bot] Aug 4, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-apigateway/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@ This can be modified as shown below:

```ts
const api = new apigateway.SpecRestApi(this, 'ExampleRestApi', {
apiDefinition: apigateway.ApiDefinition.fromInline(replacedSwagger),
// ...
endpointTypes: [apigateway.EndpointType.PRIVATE]
});
```
Expand Down