fix(apigateway): allow endpointConfiguration to be defined #9177
Conversation
Only RestApi allowed endpointConfiguration to be defined rather than both SpecRestApi and RestApi which it is relevant for.
|
apologies, first time writing typescript. Trying to get everything oriented appropriately here since Im coming from having made the changes in javascript in my own app and working to translate them back to the original. Thanks for bearing with me and appreciate any suggestions |
|
@ericzbeard My changes seem to pass tests now, was just getting unrelated failure due to docker image pull rate limits. Appreciate whenever you can take a look :). |
ericzbeard
changed the title
|
@nija-at thoughts on this? I'd like to remove my local changes since I will need to have changes updated via CICD. Thank you! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
It looks like this is already being addressed in this PR #9068. |
|
Closing this PR in favour of the duplicate #9068 that is already in progress. |
|
@nija-at thanks, missed that :) |
Only RestApi allowed endpointConfiguration to be defined rather than both SpecRestApi and RestApi which it is relevant for.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license