Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Currently,
application autoscaling
,autoscaling
, andevents
have their ownschedule
class that are very similar. They all support a subset of these static methods:at(moment)
,rate(duration)
,expression(expression)
, andcron(options)
. Because each resource has different ways of specifying itsschedule
class, this PR is not as simple as moving the class to core and removing duplicates.Solution:
This PR moves the repetitive logic to
core
as aBaseSchedule
class, with all methodsprotected
. It is called aBase
class because other resources that have a need for aschedule
should extend this and expose the necessary methods. This way, oneBaseSchedule
class can support multiple similar renditions of theschedule
property.Note:
BaseSchedule
should never need to be referenced by cdk users. This results in the PR Linter failure.autoscaling
follows the UNIX format with 5 units (source). However,application autoscaling
andevents
follows a slightly different format with 6 units (source). To accommodate both formats, I added an optionalunix
parameter tocreateCron
that if set, will return a UNIX formatted cron expression.Closes #8979
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license