-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cfn-include): add support for the Fn::Sub function #9275
Conversation
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
…::And, Fn::Not, and Fn::Or, including unit tests.
…ntrinsic functions
…ied the return type of transform to IResolvable, and updated transform docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks great! I'd like to see some small cleanup of the code, and a few more tests before I'm comfortable giving my "ShipIt".
packages/@aws-cdk/cloudformation-include/test/test-templates/fn-sub-shadow.json
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/yaml-templates.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/yaml-templates.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
---- Closes aws#9228 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #9228
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license