Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloudfront): small refactoring of the Origin API #9281

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented Jul 28, 2020

Change the Origin to an interface, from an abstract class, and change its bind protocol to return an OriginBindConfig interface.

This is in preparation for handling Origin Groups in #9109 - when time comes to handle Origin Groups, we will add a new (optional) property to OriginBindConfig, of type CfnDistribution.OriginGroupProperty, and handle it in Distribution.

BREAKING CHANGE: the property Origin.domainName has been removed


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested a review from njlynch July 28, 2020 02:22
@skinny85 skinny85 self-assigned this Jul 28, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 28, 2020
@skinny85 skinny85 force-pushed the feat/cloudfront-origin-groups-refactor branch from d4901c5 to 934a50c Compare July 28, 2020 23:00
@skinny85
Copy link
Contributor Author

@njlynch this is ready for another round of reviews. I've incorporated all of your comments, and I've also reverted the renaming of Origin to OriginBase and OriginProps to CommonOriginProps - I figured minimizing the changes in this PR is more important. Let me know what you think!

@skinny85 skinny85 requested a review from njlynch July 28, 2020 23:01
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fbc016f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cbfdc15 into aws:master Jul 29, 2020
@skinny85 skinny85 deleted the feat/cloudfront-origin-groups-refactor branch July 29, 2020 17:22
curtiseppel pushed a commit to curtiseppel/aws-cdk that referenced this pull request Aug 11, 2020
Change the Origin to an interface, from an abstract class, and change its `bind` protocol to return an `OriginBindConfig` interface.

This is in preparation for handling Origin Groups in aws#9109 - when time comes to handle Origin Groups, we will add a new (optional) property to `OriginBindConfig`, of type `CfnDistribution.OriginGroupProperty`, and handle it in `Distribution`.

BREAKING CHANGE: the property Origin.domainName has been removed

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants