fix(certificatemanager): DNS validation for wildcard certificates #9291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a certificate with automatic (Route53) DNS validation contains both a base domain name and the wildcard for that domain (e.g., `example.com` and `*.example.com`), the corresponding DNS validation records are identical. This seems to have caused problems for the automated CloudFormation DNS validation. Solving the problem by removing the redundant wildcard entries from the DomainValidationOption. fixes #9248
njlynch
changed the title
eladb
reviewed
Jul 28, 2020
eladb
approved these changes
Jul 30, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
curtiseppel
pushed a commit
to curtiseppel/aws-cdk
that referenced
this pull request
Aug 11, 2020
…s#9291) If a certificate with automatic (Route53) DNS validation contains both a base domain name and the wildcard for that domain (e.g., `example.com` and `*.example.com`), the corresponding DNS validation records are identical. This seems to have caused problems for the automated CloudFormation DNS validation. Solving the problem by removing the redundant wildcard entries from the DomainValidationOption. fixes aws#9248 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Even this merged. However, there is another use case is if the base domain name is a token - an imported value. This patch doesn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a certificate with automatic (Route53) DNS validation contains both a base
domain name and the wildcard for that domain (e.g.,
example.comand*.example.com), the corresponding DNS validation records are identical.This seems to have caused problems for the automated CloudFormation DNS
validation.
Solving the problem by removing the redundant wildcard entries from the
DomainValidationOption.
fixes #9248
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license