feat(core): implicit app for root stacks #9342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a stack is created as the root of the construct tree, we now implicitly create an `App` that serves as its parent scope. The root stack is created with the ID `Default`, which ensures that `node.uniqueId` of constructs within that stack is preserved. BREAKING CHANGE: in unit tests, the `node.path` of constructs within stacks created the root of the tree via `new Stack()` will now have a prefix `Default/` which represents an implicit `App` root. Related: aws/aws-cdk-rfcs#192
NetaNir
reviewed
Jul 31, 2020
Comment on lines
+132
to
+134
| test.equal(stack.node.findChild(p.node.id), p); | ||
| test.equal(stack.node.findChild(o.node.id), o); | ||
| test.equal(stack.node.findChild(c.node.id), c); |
There was a problem hiding this comment.
Just to make sure I understand, this was broken before? The test name is still Stack.getByPath but it's not verifying that anymore?
added 2 commits
August 3, 2020 08:12
eladb
added
the
pr-linter/exempt-readme
Co-authored-by: Neta Nir <neta1nir@gmail.com>
eladb
commented
Aug 3, 2020
eladb
commented
Aug 3, 2020
RomainMuller
approved these changes
Aug 3, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
curtiseppel
pushed a commit
to curtiseppel/aws-cdk
that referenced
this pull request
Aug 11, 2020
When a stack is created as the root of the construct tree, we now implicitly create an `App` that serves as its parent scope. The root stack is created with the ID `Default`, which ensures that `node.uniqueId` of constructs within that stack is preserved. BREAKING CHANGE: in unit tests, the `node.path` of constructs within stacks created the root of the tree via `new Stack()` will now have a prefix `Default/` which represents an implicit `App` root. Related: aws/aws-cdk-rfcs#192 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a stack is created as the root of the construct tree, we now implicitly create an
Appthat serves as its parent scope.The root stack is created with the ID
Default, which ensures thatnode.uniqueIdof constructs within that stack is preserved.BREAKING CHANGE: in unit tests, the
node.pathof constructs within stacks created the root of the tree vianew Stack()will now have a prefixDefault/which represents an implicitApproot.Related: aws/aws-cdk-rfcs#192
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license