Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cognito): move some tests into the correct describe block. #9514

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Aug 7, 2020

Some tests added later were not placed in the correct top-level describe
block.

No tests have been added, removed or modified in this change.


Before the change -

Test Suites: 7 passed, 7 total
Tests:       103 passed, 103 total
Snapshots:   0 total
Time:        17.307s, estimated 20s

After the change:

Test Suites: 7 passed, 7 total
Tests:       103 passed, 103 total
Snapshots:   0 total
Time:        17.49s

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Some tests added later were not placed in the correct top-level describe
block.

No tests have been added, removed or modified in this change.
@nija-at nija-at requested a review from a team August 7, 2020 15:22
@nija-at nija-at self-assigned this Aug 7, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 7, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 7, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3a8a3e6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 7, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6625cf7 into master Aug 7, 2020
@mergify mergify bot deleted the nija-at/cognito-test-refactor branch August 7, 2020 19:28
eladb pushed a commit that referenced this pull request Aug 10, 2020
Some tests added later were not placed in the correct top-level describe
block.

No tests have been added, removed or modified in this change.

----

Before the change -

```
Test Suites: 7 passed, 7 total
Tests:       103 passed, 103 total
Snapshots:   0 total
Time:        17.307s, estimated 20s
```

After the change:

```
Test Suites: 7 passed, 7 total
Tests:       103 passed, 103 total
Snapshots:   0 total
Time:        17.49s
```

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants