feat(core): deprecate "Construct.node" in favor of "Construct.construct" #9557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce the chance for conflicts with generated domain-specific properties in subclasses of `Construct` (see [terraform-cdk issue]), we decided that we will rename `node` to `construct`, which is less prevalent. We plan to remove the `node` API in the next major version of the AWS CDK, and therefore recommend users to migrate their code to use `construct` instead. Part of aws/aws-cdk-rfcs#192 [terraform-cdk issue]: hashicorp/terraform-cdk#230
rix0rrr
approved these changes
Aug 10, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
eladb
pushed a commit
that referenced
this pull request
Aug 11, 2020
As a follow-up for #9557, replace all usage of the deprecated `node` API with `construct`. Related: aws/aws-cdk-rfcs#192
mergify bot
pushed a commit
that referenced
this pull request
Aug 11, 2020
As a follow-up for #9557, replace all usage of the deprecated `node` API with `construct`. Related: aws/aws-cdk-rfcs#192 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
4 tasks
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce the chance for conflicts with generated domain-specific properties in subclasses of
Construct(see terraform-cdk issue), we decided that we will renamenodetoconstruct, which is less prevalent.We plan to remove the
nodeAPI in the next major version of the AWS CDK, and therefore recommend users to migrate their code to useconstructinstead.See discussion in the RFC.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license