feat(core): new annotations api

[eladb]

In CDK 2.0 the node.addWarning(), node.addError() and node.addInfo() APIs will be removed in favor of a "trait" pattern:

Annotations.of(construct).addWarning(message)

The existing APIs are still supported but marked as @deprecated.

Related: aws/aws-cdk-rfcs#192, See Design.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[rix0rrr]

I wonder if Logging is not going to give people the wrong impression. It's not so much a sequence of "this happens/that happens" (which is what most people will expect if you use the word "logging"), it's more of an annotation to a construct instead.

How about Annotations instead?

That terminology also cleanly explains why you cannot "log" without a construct to attach the message to, which otherwise will trip people up.

Just a suggestion that I request you spend a couple of minutes evaluating. Otherwise, a fine change.

I suppose the replacements across the AWSCL are forthcoming?

[eladb]

I wonder if Logging is not going to give people the wrong impression. It's not so much a sequence of "this happens/that happens" (which is what most people will expect if you use the word "logging"), it's more of an annotation to a construct instead.

How about Annotations instead?

That terminology also cleanly explains why you cannot "log" without a construct to attach the message to, which otherwise will trip people up.

Just a suggestion that I request you spend a couple of minutes evaluating. Otherwise, a fine change.

I suppose the replacements across the AWSCL are forthcoming?

I like Annotations. It will also be a nice place to add additional types of annotations in the future.

[njlynch]

I do like Annotations much better; good suggestion @rix0rrr !

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 6aca993
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).