-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): local bundling provider #9564
Conversation
@eladb let's first discuss the concept... currently works with |
Bundling is currently documented here: https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-s3-assets/README.md#asset-bundling Should I add the doc about local bundling there? Move everything to core? |
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
|
Yes I figured. Let's just keep the current api (without the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor
@eladb will leave this in Draft while I test that I can implement local bundling correctly in |
path: '/path/to/asset', | ||
bundling: { | ||
local: { | ||
tryBundler(outputDir: string, options: BundlingOptions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be tryBundle
no?
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The local bundling provider implements a method
tryBundle()
which shouldreturn
true
if local bundling was performed. Iffalse
is returned, dockerbundling will be done.
This allows to improve bundling performance when the required dependencies are
available locally.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license