revert(secretsmanager): Specify secret value at creation #9610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 07fedff.
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
njlynch
changed the title
njlynch
changed the title
eladb
approved these changes
Aug 11, 2020
|
|
||
| [see also this example of creating a secret](test/integ.secret.lit.ts) | ||
| The `Secret` construct does not allow specifying the `SecretString` property | ||
| of the `AWS::SecretsManager::Secret` resource (as this will almost always |
There was a problem hiding this comment.
Can we add some pointers/example on how to create a secretsmanager secret and reference it in a CDK app?
(Subsequent commit)
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 07fedff.
Further team discussion deemed this feature too dangerous to support within the CDK.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license