Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(s3): add option to auto delete objects upon bucket removal #9751

Closed
wants to merge 22 commits into from
Closed

feat(s3): add option to auto delete objects upon bucket removal #9751

wants to merge 22 commits into from

Commits on Aug 16, 2020

  1. feat(s3): add option to auto delete objects upon bucket removal

    @Chriscbr
    Chriscbr committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    09642e9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/clear-s3-bucket

    @Chriscbr
    Chriscbr authored Aug 16, 2020
    Configuration menu
    Copy the full SHA
    f3b9cd3 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. Merge branch 'master' into feat/clear-s3-bucket

    @Chriscbr
    Chriscbr committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    6b27429 View commit details
    Browse the repository at this point in the history

  2. Refactor to use CustomResourceProvider

    @Chriscbr
    Chriscbr committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    2d42b2e View commit details
    Browse the repository at this point in the history

  3. Update unit tests

    @Chriscbr
    Chriscbr committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    56a48d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2020

  1. Add feedback from jogold

    @Chriscbr
    Chriscbr committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    809ea22 View commit details
    Browse the repository at this point in the history

  2. Add unit tests for handler and ServiceToken

    @Chriscbr
    Chriscbr committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    83463a4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat/clear-s3-bucket

    @Chriscbr
    Chriscbr committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    4018b4d View commit details
    Browse the repository at this point in the history

  4. revert changes to handler permissions since it is singleton

    @Chriscbr
    Chriscbr committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    6ff4bec View commit details
    Browse the repository at this point in the history

  5. add unit test

    @Chriscbr
    Chriscbr committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    885b178 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into feat/clear-s3-bucket

    @Chriscbr
    Chriscbr committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    60c21f4 View commit details
    Browse the repository at this point in the history

  7. remove todo comment

    @Chriscbr
    Chriscbr committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    00f1b65 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2020

  1. remove unneeded PutObject permissions

    @Chriscbr
    Chriscbr committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    6762518 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/clear-s3-bucket

    @Chriscbr
    Chriscbr committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    92e1b9c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2020

  1. Merge branch 'master' into feat/clear-s3-bucket 

    Convert auto-delete-objects unit test to use nodeunit-shim
    @Chriscbr
    Chriscbr committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    60c16ca View commit details
    Browse the repository at this point in the history

  2. convert test file to jest

    @Chriscbr
    Chriscbr committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    2d41d98 View commit details
    Browse the repository at this point in the history

  3. rewrite mocking with jest to remove sinon dependency

    @Chriscbr
    Chriscbr committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    4e2e2ff View commit details
    Browse the repository at this point in the history

  4. refactor tests to mock S3 client cleaner, add one test

    @Chriscbr
    Chriscbr committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    1059325 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2020

  1. Merge branch 'master' into feat/clear-s3-bucket

    @Chriscbr
    Chriscbr committed Nov 8, 2020
    Configuration menu
    Copy the full SHA
    f399f67 View commit details
    Browse the repository at this point in the history

  2. fixup tests and other nitpicks

    @Chriscbr
    Chriscbr committed Nov 8, 2020
    Configuration menu
    Copy the full SHA
    99ab9c1 View commit details
    Browse the repository at this point in the history

  3. hoist aws-sdk import to global scope

    @Chriscbr
    Chriscbr committed Nov 8, 2020
    Configuration menu
    Copy the full SHA
    d35592a View commit details
    Browse the repository at this point in the history

  4. reorder imports

    @Chriscbr
    Chriscbr committed Nov 8, 2020
    Configuration menu
    Copy the full SHA
    21f5a31 View commit details
    Browse the repository at this point in the history